Repository navigation
エラーハンドリング周りの修正 - #1035
Merged
Merged
エラーハンドリング周りの修正#1035
Conversation
|
Codecov Report❌ Patch coverage is
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
Author
|
see also: misskey-dev/misskey#18168 |
salano-ym
approved these changes
Nov 19, 2026
ikasoba
approved these changes
Nov 19, 2026
| if (immediate) { | ||
| assertBoolean(immediate); | ||
| if (immediate.value) opts.call(callback, []); | ||
| if (immediate.value) opts.topCall(callback, []); |
Collaborator
There was a problem hiding this comment.
LGTM なのですが、一応補足としてコメントを残しておきます。
call から topCall とした場合、コールスタックが途切れますが、待たずに実行を予約する意図 (JS の setImmediate 相当) ならば問題なさそうです。
Member
Author
|
マージ条件を満たしていたのでマージしました。 |
Collaborator
|
🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interpreterのerrハンドラ、abortOnError周りでバグがあったので修正します。
loopなどの制御文の評価で空の無限ループが発生する